Minor MockHttpClient improvements #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpwatrous
requested review from
cRui861,
gingi,
zfengms,
wiboris,
skapur12,
NickKouds and
wanghoppe
as code owners
dpwatrous
changed the title
dpwatrous
force-pushed
the
dpwatrous/mock-http-bodies
branch
from
a4185bd
to
779c640
Compare
Codecov Report
@@ Coverage Diff @@
## main #2806 +/- ##
=======================================
Coverage 66.48% 66.49%
=======================================
Files 1232 1232
Lines 33884 33888 +4
Branches 6171 6173 +2
=======================================
+ Hits 22529 22534 +5
+ Misses 11220 11219 -1
Partials 135 135
Continue to review full report in Codecov by Sentry.
|
gingi
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for mocking UrlSearchParams bodies and fixed a minor issue where request URLs were ignored when setting expected requests.